Functionality for Reed-Solomon object encoding#3429
Closed
cthulhu-rider wants to merge 1 commit intomasterfrom
Closed
Functionality for Reed-Solomon object encoding#3429cthulhu-rider wants to merge 1 commit intomasterfrom
cthulhu-rider wants to merge 1 commit intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3429 +/- ##
==========================================
+ Coverage 20.92% 21.33% +0.40%
==========================================
Files 706 708 +2
Lines 52809 53076 +267
==========================================
+ Hits 11052 11325 +273
+ Misses 40959 40915 -44
- Partials 798 836 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
ec
branch
12 times, most recently
from
c1ebce4 to
6d97375
Compare
Contributor
Author
|
works overall. I tested this against SNs v0.47.1. Data shards are accepted well. Linker is denied:
for now im leaning towards option 1 and elimination content error in EC containers specific |
Refs #3419. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Contributor
Author
|
overlapped by #3457 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, i'm trying to implement single-level encoding. It's simpler and less resource intensive. Plus it's within current multi-level slicing restrictions like 60faa73 (smth else?)
an obvious alternative would be a two-level format, where the resulting objects of slicing by length (up to MaxObjectSize) are wrapped into new objects due to the recursive structure. I haven't found any advantages in it yet